Inline Commentary Settings Lost In .1318

[Doctordavet]

Hi, Costas,

when I updated to .1318 this morning, three of my four layouts that utilize "inline commentaries" had all of the commentary settings emptied. So when I opened those layouts, I could see the Bible; but there were no commentaries visible. When I opened the Bible View Options, all of the inline commentaries had been "deselected."

When I reselect the desired commentaries and save the layout, I can close and reopen the program with no problems. It would appear there is something wrong with the transition into .1318, and not a problem with the inline commentaries themselves.

[csterg]

Hi, Costas,

when I updated to .1318 this morning, three of my four layouts that utilize "inline commentaries" had all of the commentary settings emptied. So when I opened those layouts, I could see the Bible; but there were no commentaries visible. When I opened the Bible View Options, all of the inline commentaries had been "deselected."

When I reselect the desired commentaries and save the layout, I can close and reopen the program with no problems. It would appear there is something wrong with the transition into .1318, and not a problem with the inline commentaries themselves.

Hi Dave,
thanks for bringing this up, it shouldn't happen. IF you have kept a copy of your old config.ini i could try to see why this happens: during initialization of 1318, the settings are migrated.
Is it possible that you had 2 instance of tw running?
Costas

[JG]

Hi Costas,
I notice that if you have an in-line commentary in the Bible view in pre 1318 build and you close and then run 1318, that the in-line commentaries are not there, it is just a plain Bible view.

So I find that the config files are identical.
If I launch 1317 again then the in-line comments show.

It appears now that 1317 and 1318 cannot read each others settings

[csterg]

Hi Costas,
I notice that if you have an in-line commentary in the Bible view in pre 1318 build and you close and then run 1318, that the in-line commentaries are not there, it is just a plain Bible view.

So I find that the config files are identical.
If I launch 1317 again then the in-line comments show.

It appears now that 1317 and 1318 cannot read each others settings

OK Jon, i will test this; there is an upgrade mechanism in there, but it seems there is a glitch somewhere,
Costas

[JG]

I see it now that you have changed the separator char from , to |

[csterg]

I see it now that you have changed the separator char from , to |

Exactly; but i have made an upgrade path there but there is a glitch somewhere

[JG]

I see it now that you have changed the separator char from , to |

Exactly; but i have made an upgrade path there but there is a glitch somewhere

So testers need to be aware (when it is fixed) that after running 1318+ that if they run 1317- that they won't see any in-line commentaries as the dbv.inline.cmts.list format has changed the separator from a comma to a pipe.
The exception to this is if you only have one in-line commentary defined, in that case it still works OK.

[csterg]

I just tried again and it seems to work here.
Can you give me a path to reproduce?

[JG]

What commentaries did you set in-line?

[csterg]

random, does it matter?

[JG]

Yes it does matter because it is something wrong, somewhere.
OK I have it.
So I started with fresh config.ini
Made the test file as below, and set Barnes (C8) and this other module in-line, and they both show OK.

"test - name issue.cmt.twm".
I think you should find an issue because of the hyphen in the id/name? and I don't know why it fails if there is another module and not on its own, but there it is.

[Doctordavet]

Hi, Guys,

Thanks for getting after this. I appreciate so much your work.

This is probably related; but "commentary links" have been turned off as well. Sorry I missed that initially.

[csterg]

Should be fixed in 1319, although if you run 1318 the list of modules will be reset (sorry)
Costas

[Doctordavet]

No need for sorry! This is what beta testing/usage is all about! Thanks for making quick repairs.

[pfpeller]

Tried .1319 this morning and my commentary links did dissapear, but now that I have reconfigured them everything seems to be working. Thanks!